I am just wondering, what to "clean up" more - maybe you can offer some practical example?..
sorry, i had not have time to get back an this yesterday. also i thought it is unfair to complain without beeing a registered user. now i have registered, and can continue on what are some of the main points of what i ment: again sorry for my harsh words, this wasn't really nice from me and it's not my intention to flame on you or minibb.
first of all: you should really think of formatting your source-code. i checked it with several editors, to be really sure that there's nothing going wrong at me - i could not believe that you did not do any indenting at all.
2.: DB_query(arg1,arg2) might be a timesafing function for you, who know what the source-code does. for any other, who wants to learn what's happening, it's very hard do overlook, what's going on - you should at least use constants for the first parameter instead of just numbers, especially as you're using tons of global variables inside this function.
3.: i've never seen true/false in the code (as i rembember at the moment) but always 0/1 - that might be a matter of taste of course.
4.: there are in my opinion some design-issues, for example: on the one hand you use logged_admin = true/false to identify an admin in minibb but on the other hand you set the user_id explicit to 1, when the admin is posting in the forum.
that might be no problem with minibb itself, cause there's only one admin allowed. i'm currently working to combine minibb with an other project at pixelquelle.de and in the image-database we have other user-levels with more than one admin allowed. i removed this user_id = 1 and it seems to work, but it isn't very well tested, yet.
please keep in mind: it's not on flaming, but on making live easier for other developers like me :-)
regards <-harald |